Lint Analysis Results Report for XSTRING.CPP |
Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP |
---|---|
Project: | UTStaticLib2008 |
Solution: | UsingStaticLib.sln [configuration: Debug] |
Analysis Status: | Complete |
Last Analysed: | 08 October 2008, 12:22:45 |
Total Issues: | 41 |
Elective Notes: | 11 (26.83%) |
Informational: | 28 (68.29%) |
Warnings: | 2 (4.88%) |
Errors: | 0 (0.00%) |
Internal Errors: | 0 (0.00%) |
Fatal Errors: | 0 (0.00%) |
User: | Anna |
Computer: | GABRIELLE |
Issue count by category ![]() Issue count by message number ![]() |
Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
---|---|---|---|---|---|---|
1 | Information | 2 | 1776 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 36 | Converting a string literal to char * is not const safe (initialization) |
2 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 40 | Ignoring return value of function 'GetProfileStringA(const char *, const char *, const char *, char *, unsigned long)' (compare with line 7671, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
3 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 7671 | Location cited in prior message |
4 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 51 | Symbol 'CStringT' did not appear in the constructor initializer list -- Effective C++ #12 |
5 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 55 | Symbol 'CStringT' did not appear in the constructor initializer list -- Effective C++ #12 |
6 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 57 | Parameter 'psz' (line 54) could be declared const --- Eff. C++ 3rd Ed. item 3 |
7 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 54 | Location cited in prior message |
8 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 60 | Symbol 'CStringT' did not appear in the constructor initializer list -- Effective C++ #12 |
9 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 65 | Symbol 'CStringT' did not appear in the constructor initializer list -- Effective C++ #12 |
10 | Warning | 3 | 1529 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 82 | Symbol 'COXString::operator=(const COXString &)' not first checking for assignment to this -- Effective C++ #17 & Eff. C++ 3rd Ed. item 11 |
11 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 91 | Loss of sign (arg. no. 1) (char to unsigned int) |
12 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 108 | Variable 'nLength' (line 87) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
13 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 87 | Location cited in prior message |
14 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 113 | Loss of sign (arg. no. 1) (char to unsigned int) |
15 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 136 | Loss of sign (arg. no. 1) (char to unsigned int) |
16 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 174 | Loss of sign (arg. no. 1) (char to unsigned int) |
17 | Information | 2 | 1762 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 177 | Member function 'COXString::IsInt(void)' could be made const --- Eff. C++ 3rd Ed. item 3 |
18 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 185 | Loss of sign (arg. no. 1) (char to unsigned int) |
19 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 191 | Loss of sign (arg. no. 1) (char to unsigned int) |
20 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 199 | Loss of sign (arg. no. 1) (char to unsigned int) |
21 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 202 | Loss of sign (arg. no. 1) (char to unsigned int) |
22 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 212 | Loss of sign (arg. no. 1) (char to unsigned int) |
23 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 215 | Loss of sign (arg. no. 1) (char to unsigned int) |
24 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 219 | Loss of sign (arg. no. 1) (char to unsigned int) |
25 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 223 | do ... while(0); |
26 | Information | 2 | 1762 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 227 | Member function 'COXString::IsNumber(void)' could be made const --- Eff. C++ 3rd Ed. item 3 |
27 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 257 | Loss of sign (arg. no. 2) (int to unsigned long) |
28 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 270 | Parameter 'pszFormat' (line 229) could be declared const --- Eff. C++ 3rd Ed. item 3 |
29 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 229 | Location cited in prior message |
30 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 270 | Parameter 'nString' (line 229) could be declared const --- Eff. C++ 3rd Ed. item 3 |
31 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 229 | Location cited in prior message |
32 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 270 | Parameter 'rgpsz' (line 229) could be declared const --- Eff. C++ 3rd Ed. item 3 |
33 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 229 | Location cited in prior message |
34 | Information | 2 | 818 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 270 | Pointer parameter 'rgpsz' (line 229) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
35 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 229 | Location cited in prior message |
36 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 270 | Variable 'pchDestBegin' (line 242) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
37 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 242 | Location cited in prior message |
38 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 279 | do ... while(0); |
39 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 280 | Variable 'nLength' (line 274) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
40 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 274 | Location cited in prior message |
41 | Information | 2 | 766 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP | 292 | Header file '..\..\Include\UTB64Bit.h' not used in module 'D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP' |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP (C++) LPTSTR pszDecimalDefault = _T(","); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(36): error 1776: (Info -- Converting a string literal to char * is not const safe (initialization)) *pszDecimalDestination)); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(40): error 534: (Warning -- Ignoring return value of function 'GetProfileStringA(const char *, const char *, const char *, char *, unsigned long)' (compare with line 7671, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h)) C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(7671): error 830: (Info -- Location cited in prior message) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(51): error 1928: (Note -- Symbol 'CStringT' did not appear in the constructor initializer list -- Effective C++ #12) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(55): error 1928: (Note -- Symbol 'CStringT' did not appear in the constructor initializer list -- Effective C++ #12) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(57): error 952: (Note -- Parameter 'psz' (line 54) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(54): error 830: (Info -- Location cited in prior message) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(60): error 1928: (Note -- Symbol 'CStringT' did not appear in the constructor initializer list -- Effective C++ #12) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(65): error 1928: (Note -- Symbol 'CStringT' did not appear in the constructor initializer list -- Effective C++ #12) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(82): error 1529: (Warning -- Symbol 'COXString::operator=(const COXString &)' not first checking for assignment to this -- Effective C++ #17 & Eff. C++ 3rd Ed. item 11) while (_istspace(*lpsz)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(91): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(108): error 953: (Note -- Variable 'nLength' (line 87) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(87): error 830: (Info -- Location cited in prior message) while((0 <= nStringIndex) && _istspace(GetAt(nStringIndex)) ) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(113): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) if (_istspace(GetAt(nPosIn))) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(136): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) if (!_istdigit(GetAt(nIndex))) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(174): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(177): error 1762: (Info -- Member function 'COXString::IsInt(void)' could be made const --- Eff. C++ 3rd Ed. item 3) while (_istspace(*pc)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(185): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) while (_istdigit(*pc)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(191): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) if (!bDigit && !_istdigit(*pc)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(199): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) while (_istdigit(*pc)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(202): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) if (!_istdigit(*pc)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(212): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) while (_istdigit(*pc)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(215): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) while (_istspace(*pc)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(219): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) #... LE, __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */ ASSERT(pc <= (((LPCTSTR)*this) + GetLength())); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(223): error 717: (Info -- do ... while(0);) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(227): error 1762: (Info -- Member function 'COXString::IsNumber(void)' could be made const --- Eff. C++ 3rd Ed. item 3) UTBStr::tcscpy(pchDest, nTotalLen, rgpsz[i]); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(257): error 732: (Info -- Loss of sign (arg. no. 2) (int to unsigned long)) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(270): error 952: (Note -- Parameter 'pszFormat' (line 229) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(229): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(270): error 952: (Note -- Parameter 'nString' (line 229) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(229): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(270): error 952: (Note -- Parameter 'rgpsz' (line 229) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(229): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(270): error 818: (Info -- Pointer parameter 'rgpsz' (line 229) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(229): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(270): error 953: (Note -- Variable 'pchDestBegin' (line 242) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(242): error 830: (Info -- Location cited in prior message) #... AfxDebugBreak() ; } while (0) /*lint -restore */ ASSERT(GetLength() == nLength); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(279): error 717: (Info -- do ... while(0);) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(280): error 953: (Note -- Variable 'nLength' (line 274) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(274): error 830: (Info -- Location cited in prior message) --- Wrap-up for Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP(292): error 766: (Info -- Header file '..\..\Include\UTB64Bit.h' not used in module 'D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\XSTRING.CPP') --- Global Wrap-up error 900: (Note -- Successful completion, 41 messages produced)