Lint Analysis Results Report for OXUUDec.cpp |
Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp |
---|---|
Project: | UTStaticLib2008 |
Solution: | UsingStaticLib.sln [configuration: Debug] |
Analysis Status: | Complete |
Last Analysed: | 08 October 2008, 12:21:29 |
Total Issues: | 69 |
Elective Notes: | 11 (15.94%) |
Informational: | 48 (69.57%) |
Warnings: | 10 (14.49%) |
Errors: | 0 (0.00%) |
Internal Errors: | 0 (0.00%) |
Fatal Errors: | 0 (0.00%) |
User: | Anna |
Computer: | GABRIELLE |
Issue count by category ![]() Issue count by message number ![]() |
Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
---|---|---|---|---|---|---|
1 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 58 | Symbol 'CObject' did not appear in the constructor initializer list -- Effective C++ #12 |
2 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 75 | Parameter 'EncodedFilNam' (line 61) could be declared const --- Eff. C++ 3rd Ed. item 3 |
3 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 61 | Location cited in prior message |
4 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 75 | Variable 'res' (line 69) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
5 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 69 | Location cited in prior message |
6 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 107 | Parameter 'pszDir' (line 77) could be declared const --- Eff. C++ 3rd Ed. item 3 |
7 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 77 | Location cited in prior message |
8 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 107 | Parameter 'EncodedFilNam' (line 77) could be declared const --- Eff. C++ 3rd Ed. item 3 |
9 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 77 | Location cited in prior message |
10 | Information | 2 | 801 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 159 | Use of goto is deprecated |
11 | Information | 2 | 801 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 191 | Use of goto is deprecated |
12 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 196 | Ignoring return value of function 'CFile::GetStatus(struct CFileStatus &) const' (compare with line 1059, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afx.h) |
13 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afx.h | 1059 | Location cited in prior message |
14 | Information | 2 | 801 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 209 | Use of goto is deprecated |
15 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 216 | Ignoring return value of function 'GetTempPathA(unsigned long, char *)' (compare with line 7997, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
16 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 7997 | Location cited in prior message |
17 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 220 | Ignoring return value of function 'GetTempFileNameA(const char *, const char *, unsigned int, char *)' (compare with line 8017, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h) |
18 | Information | 2 | 830 | C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h | 8017 | Location cited in prior message |
19 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 236 | Ignoring return value of function '_mkdir(const char *)' (compare with line 70, file C:\Program Files\Microsoft Visual Studio 9.0\VC\include\direct.h) |
20 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\include\direct.h | 70 | Location cited in prior message |
21 | Information | 2 | 801 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 245 | Use of goto is deprecated |
22 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 284 | Parameter 'pszDir' (line 109) could be declared const --- Eff. C++ 3rd Ed. item 3 |
23 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 109 | Location cited in prior message |
24 | Warning | 3 | 550 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 284 | Symbol 'success' (line 125) not accessed |
25 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 125 | Location cited in prior message |
26 | Warning | 3 | 1540 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 300 | Pointer member 'COXUUDecoder::m_buf' (line 69, file ..\..\Include\oxuudec.h) neither freed nor zeroed by destructor -- Effective C++ #6 |
27 | Information | 2 | 830 | ..\..\Include\oxuudec.h | 69 | Location cited in prior message |
28 | Warning | 3 | 1540 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 300 | Pointer member 'COXUUDecoder::m_bufm1' (line 70, file ..\..\Include\oxuudec.h) neither freed nor zeroed by destructor -- Effective C++ #6 |
29 | Information | 2 | 830 | ..\..\Include\oxuudec.h | 70 | Location cited in prior message |
30 | Warning | 3 | 1540 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 300 | Pointer member 'COXUUDecoder::m_bufm2' (line 71, file ..\..\Include\oxuudec.h) neither freed nor zeroed by destructor -- Effective C++ #6 |
31 | Information | 2 | 830 | ..\..\Include\oxuudec.h | 71 | Location cited in prior message |
32 | Warning | 3 | 1540 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 300 | Pointer member 'COXUUDecoder::m_bufm3' (line 72, file ..\..\Include\oxuudec.h) neither freed nor zeroed by destructor -- Effective C++ #6 |
33 | Information | 2 | 830 | ..\..\Include\oxuudec.h | 72 | Location cited in prior message |
34 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 322 | Loss of sign (assignment) (int to unsigned int) |
35 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 351 | Parameter 'n' (line 303) could be declared const --- Eff. C++ 3rd Ed. item 3 |
36 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 303 | Location cited in prior message |
37 | Information | 2 | 1762 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 351 | Member function 'COXUUDecoder::FixEOLN(char *, int)' could be made const --- Eff. C++ 3rd Ed. item 3 |
38 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 371 | Loss of sign (arg. no. 2) (int to unsigned int) |
39 | Information | 2 | 1752 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 386 | catch parameter is not a reference -- More Effective C++ #13 |
40 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 386 | do ... while(0); |
41 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 393 | Pointer variable 'result' (line 366) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
42 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 366 | Location cited in prior message |
43 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 434 | Parameter 'buf' (line 395) could be declared const --- Eff. C++ 3rd Ed. item 3 |
44 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 395 | Location cited in prior message |
45 | Information | 2 | 818 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 434 | Pointer parameter 'buf' (line 395) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
46 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 395 | Location cited in prior message |
47 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 434 | Parameter 'n' (line 395) could be declared const --- Eff. C++ 3rd Ed. item 3 |
48 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 395 | Location cited in prior message |
49 | Information | 2 | 1762 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 434 | Member function 'COXUUDecoder::IsGoodBuf(char *, int)' could be made const --- Eff. C++ 3rd Ed. item 3 |
50 | Information | 2 | 701 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 471 | Shift left of signed quantity (int) |
51 | Information | 2 | 702 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 471 | Shift right of signed quantity (int) |
52 | Information | 2 | 701 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 475 | Shift left of signed quantity (int) |
53 | Information | 2 | 702 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 475 | Shift right of signed quantity (int) |
54 | Information | 2 | 701 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 479 | Shift left of signed quantity (int) |
55 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 487 | Loss of sign (arg. no. 2) (int to unsigned int) |
56 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 501 | Loss of sign (assignment) (char to unsigned char) |
57 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 506 | Loss of sign (assignment) (char to unsigned char) |
58 | Information | 2 | 701 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 513 | Shift left of signed quantity (int) |
59 | Information | 2 | 702 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 513 | Shift right of signed quantity (int) |
60 | Information | 2 | 1752 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 520 | catch parameter is not a reference -- More Effective C++ #13 |
61 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 520 | do ... while(0); |
62 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 527 | Pointer variable 'from' (line 449) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
63 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 449 | Location cited in prior message |
64 | Information | 2 | 1762 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 527 | Member function 'COXUUDecoder::UUD1Line(CFile *, char *)' could be made const --- Eff. C++ 3rd Ed. item 3 |
65 | Information | 2 | 801 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 594 | Use of goto is deprecated |
66 | Information | 2 | 801 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 638 | Use of goto is deprecated |
67 | Information | 2 | 801 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 671 | Use of goto is deprecated |
68 | Warning | 3 | 550 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 690 | Symbol 'res' (line 575) not accessed |
69 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp | 575 | Location cited in prior message |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp (C++) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(58): error 1928: (Note -- Symbol 'CObject' did not appear in the constructor initializer list -- Effective C++ #12) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(75): error 952: (Note -- Parameter 'EncodedFilNam' (line 61) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(61): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(75): error 953: (Note -- Variable 'res' (line 69) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(69): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(107): error 952: (Note -- Parameter 'pszDir' (line 77) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(77): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(107): error 952: (Note -- Parameter 'EncodedFilNam' (line 77) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(77): error 830: (Info -- Location cited in prior message) goto badfilename; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(159): error 801: (Info -- Use of goto is deprecated) goto badfilename1; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(191): error 801: (Info -- Use of goto is deprecated) pEncodFil->GetStatus(status); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(196): error 534: (Warning -- Ignoring return value of function 'CFile::GetStatus(struct CFileStatus &) const' (compare with line 1059, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afx.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afx.h(1059): error 830: (Info -- Location cited in prior message) goto badfilename; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(209): error 801: (Info -- Use of goto is deprecated) GetTempPath(_MAX_PATH, szPath); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(216): error 534: (Warning -- Ignoring return value of function 'GetTempPathA(unsigned long, char *)' (compare with line 7997, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h)) C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(7997): error 830: (Info -- Location cited in prior message) sTempTargetName.GetBuffer(_MAX_PATH+1)); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(220): error 534: (Warning -- Ignoring return value of function 'GetTempFileNameA(const char *, const char *, unsigned int, char *)' (compare with line 8017, file C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h)) C:\Program Files\Microsoft SDKs\Windows\v6.0A\include\winbase.h(8017): error 830: (Info -- Location cited in prior message) _mkdir(pszDir); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(236): error 534: (Warning -- Ignoring return value of function '_mkdir(const char *)' (compare with line 70, file C:\Program Files\Microsoft Visual Studio 9.0\VC\include\direct.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\include\direct.h(70): error 830: (Info -- Location cited in prior message) goto badfilename; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(245): error 801: (Info -- Use of goto is deprecated) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(284): error 952: (Note -- Parameter 'pszDir' (line 109) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(109): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(284): error 550: (Warning -- Symbol 'success' (line 125) not accessed) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(125): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(300): error 1540: (Warning -- Pointer member 'COXUUDecoder::m_buf' (line 69, file ..\..\Include\oxuudec.h) neither freed nor zeroed by destructor -- Effective C++ #6) ..\..\Include\oxuudec.h(69): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(300): error 1540: (Warning -- Pointer member 'COXUUDecoder::m_bufm1' (line 70, file ..\..\Include\oxuudec.h) neither freed nor zeroed by destructor -- Effective C++ #6) ..\..\Include\oxuudec.h(70): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(300): error 1540: (Warning -- Pointer member 'COXUUDecoder::m_bufm2' (line 71, file ..\..\Include\oxuudec.h) neither freed nor zeroed by destructor -- Effective C++ #6) ..\..\Include\oxuudec.h(71): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(300): error 1540: (Warning -- Pointer member 'COXUUDecoder::m_bufm3' (line 72, file ..\..\Include\oxuudec.h) neither freed nor zeroed by destructor -- Effective C++ #6) ..\..\Include\oxuudec.h(72): error 830: (Info -- Location cited in prior message) len = n; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(322): error 732: (Info -- Loss of sign (assignment) (int to unsigned int)) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(351): error 952: (Note -- Parameter 'n' (line 303) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(303): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(351): error 1762: (Info -- Member function 'COXUUDecoder::FixEOLN(char *, int)' could be made const --- Eff. C++ 3rd Ed. item 3) result = (LPSTR)pFile->ReadString((LPTSTR)s, n); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(371): error 732: (Info -- Loss of sign (arg. no. 2) (int to unsigned int)) #... tch (CFileException* e) { ASSERT(e->IsKindOf(RUNTIME_CLASS(CFileException) CATCH(CFileException, e) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(386): error 1752: (Info -- catch parameter is not a reference -- More Effective C++ #13) #... ugBreak() ; } while (0) /*lint -restore */ #... CLASS(CFileException))); _afxExceptionLink.m_pException = e; CATCH(CFileException, e) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(386): error 717: (Info -- do ... while(0);) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(393): error 954: (Note -- Pointer variable 'result' (line 366) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(366): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(434): error 952: (Note -- Parameter 'buf' (line 395) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(395): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(434): error 818: (Info -- Pointer parameter 'buf' (line 395) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(395): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(434): error 952: (Note -- Parameter 'n' (line 395) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(395): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(434): error 1762: (Info -- Member function 'COXUUDecoder::IsGoodBuf(char *, int)' could be made const --- Eff. C++ 3rd Ed. item 3) *(to++) = (unsigned char)(((*from - 0x20) << 2) | (((*(from + 1) - 0x20) >> 4) & 0x03)); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(471): error 701: (Info -- Shift left of signed quantity (int)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(471): error 702: (Info -- Shift right of signed quantity (int)) *(to++) = (unsigned char)(((*from - 0x20) << 4) | (((*(from + 1) - 0x20) >> 2) & 0x0f)); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(475): error 701: (Info -- Shift left of signed quantity (int)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(475): error 702: (Info -- Shift right of signed quantity (int)) *(to++) = (unsigned char)(((*from - 0x20) << 6) | (( *(from + 1) - 0x20 ) & 0x3f)); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(479): error 701: (Info -- Shift left of signed quantity (int)) pFile->Write(binbuf, len); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(487): error 732: (Info -- Loss of sign (arg. no. 2) (int to unsigned int)) c0 = buf[j]; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(501): error 732: (Info -- Loss of sign (assignment) (char to unsigned char)) c1 = buf[j + 1]; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(506): error 732: (Info -- Loss of sign (assignment) (char to unsigned char)) x = (unsigned char)(((c0 - 0x20) << c[0][i]) + (((c1 - 0x20) >> c[1][i]) & c[2][i])); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(513): error 701: (Info -- Shift left of signed quantity (int)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(513): error 702: (Info -- Shift right of signed quantity (int)) #... tch (CFileException* e) { ASSERT(e->IsKindOf(RUNTIME_CLASS(CFileException) CATCH(CFileException, e) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(520): error 1752: (Info -- catch parameter is not a reference -- More Effective C++ #13) #... ugBreak() ; } while (0) /*lint -restore */ #... CLASS(CFileException))); _afxExceptionLink.m_pException = e; CATCH(CFileException, e) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(520): error 717: (Info -- do ... while(0);) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(527): error 954: (Note -- Pointer variable 'from' (line 449) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(449): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(527): error 1762: (Info -- Member function 'COXUUDecoder::UUD1Line(CFile *, char *)' could be made const --- Eff. C++ 3rd Ed. item 3) goto retry; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(594): error 801: (Info -- Use of goto is deprecated) goto nextline; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(638): error 801: (Info -- Use of goto is deprecated) goto nextline; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(671): error 801: (Info -- Use of goto is deprecated) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(690): error 550: (Warning -- Symbol 'res' (line 575) not accessed) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXUUDec.cpp(575): error 830: (Info -- Location cited in prior message) --- Global Wrap-up error 900: (Note -- Successful completion, 69 messages produced)