Issue count by category  Issue count by message number  |
Lint Analysis Results Report for OXMDIFloatWnd.cpp |
| Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp |
|---|---|
| Project: | UTStaticLib2008 |
| Solution: | UsingStaticLib.sln [configuration: Debug] |
| Analysis Status: | Complete |
| Last Analysed: | 08 October 2008, 12:08:59 |
| Total Issues: | 37 |
| Elective Notes: | 11 (29.73%) |
| Informational: | 21 (56.76%) |
| Warnings: | 5 (13.51%) |
| Errors: | 0 (0.00%) |
| Internal Errors: | 0 (0.00%) |
| Fatal Errors: | 0 (0.00%) |
| User: | Anna |
| Computer: | GABRIELLE |
Issue count by category Issue count by message number |
| Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
|---|---|---|---|---|---|---|
| 1 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 66 | Symbol 'COXMDIChildWndSizeDock' did not appear in the constructor initializer list -- Effective C++ #12 |
| 2 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 114 | Ignoring return value of function 'CWnd::SetParent(CWnd *)' (compare with line 2460, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 3 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2460 | Location cited in prior message |
| 4 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 118 | Parameter 'dwBarStyle' (line 88) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 5 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 88 | Location cited in prior message |
| 6 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 156 | Variable 'pBar' (line 146) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 7 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 146 | Location cited in prior message |
| 8 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 158 | Variable 'pDock' (line 139) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 9 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 139 | Location cited in prior message |
| 10 | Warning | 3 | 525 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 173 | Negative indentation from line 172 |
| 11 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 172 | Location cited in prior message |
| 12 | Information | 2 | 725 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 175 | Expected positive indentation from line 172 |
| 13 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 172 | Location cited in prior message |
| 14 | Information | 2 | 725 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 176 | Expected positive indentation from line 172 |
| 15 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 172 | Location cited in prior message |
| 16 | Information | 2 | 725 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 177 | Expected positive indentation from line 172 |
| 17 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 172 | Location cited in prior message |
| 18 | Warning | 3 | 525 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 178 | Negative indentation from line 172 |
| 19 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 172 | Location cited in prior message |
| 20 | Warning | 3 | 613 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 182 | Possible use of null pointer 'unknown-name' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp: lines 163, 171] |
| 21 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 163 | Reference cited in prior message |
| 22 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 171 | Reference cited in prior message |
| 23 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 183 | Variable 'pDock' (line 164) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 24 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 164 | Location cited in prior message |
| 25 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 210 | do ... while(0); |
| 26 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 215 | Variable 'pBar' (line 207) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
| 27 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 207 | Location cited in prior message |
| 28 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 215 | Pointer variable 'pBar' (line 207) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
| 29 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 207 | Location cited in prior message |
| 30 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 227 | Ignoring return value of function 'CWnd::SetWindowPos(const CWnd *, int, int, int, int, unsigned int)' (compare with line 2265, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
| 31 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2265 | Location cited in prior message |
| 32 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 235 | Parameter 'hMenu' (line 231) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 33 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 231 | Location cited in prior message |
| 34 | Elective Note | 1 | 1961 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 235 | virtual member function 'COXMDIFloatWnd::OnAddContextMenuItems(struct HMENU__ *)' could be made const --- Eff. C++ 3rd Ed. item 3 |
| 35 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 241 | Parameter 'pSysMenu' (line 237) could be declared const --- Eff. C++ 3rd Ed. item 3 |
| 36 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 237 | Location cited in prior message |
| 37 | Elective Note | 1 | 1961 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp | 241 | virtual member function 'COXMDIFloatWnd::OnAddSystemMenuItems(CMenu *)' could be made const --- Eff. C++ 3rd Ed. item 3 |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp (C++)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(66): error 1928: (Note -- Symbol 'COXMDIChildWndSizeDock' did not appear in the constructor initializer list -- Effective C++ #12)
m_wndMDIDockBar.SetParent(this);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(114): error 534: (Warning -- Ignoring return value of function 'CWnd::SetParent(CWnd *)' (compare with line 2460, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2460): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(118): error 952: (Note -- Parameter 'dwBarStyle' (line 88) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(88): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(156): error 953: (Note -- Variable 'pBar' (line 146) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(146): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(158): error 953: (Note -- Variable 'pDock' (line 139) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(139): error 830: (Info -- Location cited in prior message)
{
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(173): error 525: (Warning -- Negative indentation from line 172)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(172): error 830: (Info -- Location cited in prior message)
CMDIFloat_Parent::OnClose(); // close the window
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(175): error 725: (Info -- Expected positive indentation from line 172)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(172): error 830: (Info -- Location cited in prior message)
delete pBar; // now explicitly delete the control bar
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(176): error 725: (Info -- Expected positive indentation from line 172)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(172): error 830: (Info -- Location cited in prior message)
return;
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(177): error 725: (Info -- Expected positive indentation from line 172)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(172): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(178): error 525: (Warning -- Negative indentation from line 172)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(172): error 830: (Info -- Location cited in prior message)
((COXSizeControlBar*)pBar)->OnHide();
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(182): error 613: (Warning -- Possible use of null pointer 'unknown-name' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp: lines 163, 171])
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(163): error 831: (Info -- Reference cited in prior message)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(171): error 831: (Info -- Reference cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(183): error 953: (Note -- Variable 'pDock' (line 164) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(164): error 830: (Info -- Location cited in prior message)
#... , __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */
ASSERT(pBar->m_pDockContext != NULL);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(210): error 717: (Info -- do ... while(0);)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(215): error 953: (Note -- Variable 'pBar' (line 207) could be declared as const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(207): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(215): error 954: (Note -- Pointer variable 'pBar' (line 207) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(207): error 830: (Info -- Location cited in prior message)
SWP_NOSIZE|SWP_NOMOVE);
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(227): error 534: (Warning -- Ignoring return value of function 'CWnd::SetWindowPos(const CWnd *, int, int, int, int, unsigned int)' (compare with line 2265, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h))
C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2265): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(235): error 952: (Note -- Parameter 'hMenu' (line 231) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(231): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(235): error 1961: (Note -- virtual member function 'COXMDIFloatWnd::OnAddContextMenuItems(struct HMENU__ *)' could be made const --- Eff. C++ 3rd Ed. item 3)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(241): error 952: (Note -- Parameter 'pSysMenu' (line 237) could be declared const --- Eff. C++ 3rd Ed. item 3)
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(237): error 830: (Info -- Location cited in prior message)
}
D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXMDIFloatWnd.cpp(241): error 1961: (Note -- virtual member function 'COXMDIFloatWnd::OnAddSystemMenuItems(CMenu *)' could be made const --- Eff. C++ 3rd Ed. item 3)
--- Global Wrap-up
error 900: (Note -- Successful completion, 37 messages produced)