Lint Analysis Results Report for OXHashTable.cpp |
Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp |
---|---|
Project: | UTStaticLib2008 |
Solution: | UsingStaticLib.sln [configuration: Debug] |
Analysis Status: | Complete |
Last Analysed: | 08 October 2008, 12:05:31 |
Total Issues: | 55 |
Elective Notes: | 23 (41.82%) |
Informational: | 28 (50.91%) |
Warnings: | 4 (7.27%) |
Errors: | 0 (0.00%) |
Internal Errors: | 0 (0.00%) |
Fatal Errors: | 0 (0.00%) |
User: | Anna |
Computer: | GABRIELLE |
Issue count by category ![]() Issue count by message number ![]() |
Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
---|---|---|---|---|---|---|
1 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 24 | Symbol 'HashNode::pNext' did not appear in the constructor initializer list -- Effective C++ #12 |
2 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 24 | Symbol 'HashNode::szName' did not appear in the constructor initializer list -- Effective C++ #12 |
3 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 24 | Symbol 'HashNode::dwData' did not appear in the constructor initializer list -- Effective C++ #12 |
4 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 24 | Symbol 'HashNode::nHashValue' did not appear in the constructor initializer list -- Effective C++ #12 |
5 | Warning | 3 | 1401 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 28 | member 'HashNode::nHashValue' (line 28, file ..\..\Include\OXHashTable.h) not initialized by constructor --- Eff. C++ 3rd Ed. item 4 & Eff. C++ 3rd Ed. item 13 |
6 | Information | 2 | 830 | ..\..\Include\OXHashTable.h | 28 | Location cited in prior message |
7 | Information | 2 | 1740 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 34 | pointer member 'HashNode::pNext' (line 25, file ..\..\Include\OXHashTable.h) not directly freed or zeroed by destructor -- Effective C++ #6 |
8 | Information | 2 | 830 | ..\..\Include\OXHashTable.h | 25 | Location cited in prior message |
9 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 41 | Symbol 'COXHashTable::m_nHashTableSize' did not appear in the constructor initializer list -- Effective C++ #12 |
10 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 41 | Symbol 'COXHashTable::m_bCaseSensitive' did not appear in the constructor initializer list -- Effective C++ #12 |
11 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 41 | Symbol 'COXHashTable::m_pHashTable' did not appear in the constructor initializer list -- Effective C++ #12 |
12 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 42 | Ignoring return value of function 'COXHashTable::CommonConstruct(int)' (compare with line 81, file ..\..\Include\OXHashTable.h) |
13 | Information | 2 | 830 | ..\..\Include\OXHashTable.h | 81 | Location cited in prior message |
14 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 46 | Symbol 'COXHashTable::m_nHashTableSize' did not appear in the constructor initializer list -- Effective C++ #12 |
15 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 46 | Symbol 'COXHashTable::m_bCaseSensitive' did not appear in the constructor initializer list -- Effective C++ #12 |
16 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 46 | Symbol 'COXHashTable::m_pHashTable' did not appear in the constructor initializer list -- Effective C++ #12 |
17 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 47 | Ignoring return value of function 'COXHashTable::CommonConstruct(int)' (compare with line 81, file ..\..\Include\OXHashTable.h) |
18 | Information | 2 | 830 | ..\..\Include\OXHashTable.h | 81 | Location cited in prior message |
19 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 56 | Loss of sign (arg. no. 1) (int to unsigned int) |
20 | Warning | 3 | 1551 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 61 | Function may throw exception '...' in destructor 'COXHashTable::~COXHashTable(void)' -- More Effective C++ #11 & Eff. C++ 3rd Ed. item 8 |
21 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 71 | Parameter 'bCase' (line 68) could be declared const --- Eff. C++ 3rd Ed. item 3 |
22 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 68 | Location cited in prior message |
23 | Information | 2 | 1762 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 76 | Member function 'COXHashTable::GetCaseSensitive(void)' could be made const --- Eff. C++ 3rd Ed. item 3 |
24 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 98 | Parameter 'nHashSize' (line 81) could be declared const --- Eff. C++ 3rd Ed. item 3 |
25 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 81 | Location cited in prior message |
26 | Information | 2 | 774 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 136 | Boolean within 'if' always evaluates to False [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp: lines 134, 136] |
27 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 134 | Reference cited in prior message |
28 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 136 | Reference cited in prior message |
29 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 158 | Parameter 'dwData' (line 126) could be declared const --- Eff. C++ 3rd Ed. item 3 |
30 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 126 | Location cited in prior message |
31 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 158 | Parameter 'sz' (line 126) could be declared const --- Eff. C++ 3rd Ed. item 3 |
32 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 126 | Location cited in prior message |
33 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 169 | Variable 'pNode' (line 163) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
34 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 163 | Location cited in prior message |
35 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 169 | Pointer variable 'pNode' (line 163) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
36 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 163 | Location cited in prior message |
37 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 169 | Parameter 'sz' (line 160) could be declared const --- Eff. C++ 3rd Ed. item 3 |
38 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 160 | Location cited in prior message |
39 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 207 | Variable 'nHashVal' (line 174) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
40 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 174 | Location cited in prior message |
41 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 207 | Parameter 'sz' (line 171) could be declared const --- Eff. C++ 3rd Ed. item 3 |
42 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 171 | Location cited in prior message |
43 | Information | 2 | 737 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 219 | Loss of sign in promotion from int to unsigned int |
44 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 225 | Loss of sign (arg. no. 1) (char to unsigned int) |
45 | Information | 2 | 834 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 226 | Operator '-' followed by operator '+' is confusing. Use parentheses. |
46 | Information | 2 | 737 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 226 | Loss of sign in promotion from int to unsigned int |
47 | Information | 2 | 737 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 228 | Loss of sign in promotion from int to unsigned int |
48 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 255 | Variable 'nHashVal' (line 238) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
49 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 238 | Location cited in prior message |
50 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 255 | Parameter 'sz' (line 235) could be declared const --- Eff. C++ 3rd Ed. item 3 |
51 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 235 | Location cited in prior message |
52 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 317 | Variable 'pNode' (line 302) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
53 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 302 | Location cited in prior message |
54 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 317 | Pointer variable 'pNode' (line 302) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
55 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp | 302 | Location cited in prior message |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp (C++) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(24): error 1927: (Note -- Symbol 'HashNode::pNext' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(24): error 1927: (Note -- Symbol 'HashNode::szName' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(24): error 1927: (Note -- Symbol 'HashNode::dwData' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(24): error 1927: (Note -- Symbol 'HashNode::nHashValue' did not appear in the constructor initializer list -- Effective C++ #12) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(28): error 1401: (Warning -- member 'HashNode::nHashValue' (line 28, file ..\..\Include\OXHashTable.h) not initialized by constructor --- Eff. C++ 3rd Ed. item 4 & Eff. C++ 3rd Ed. item 13) ..\..\Include\OXHashTable.h(28): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(34): error 1740: (Info -- pointer member 'HashNode::pNext' (line 25, file ..\..\Include\OXHashTable.h) not directly freed or zeroed by destructor -- Effective C++ #6) ..\..\Include\OXHashTable.h(25): error 830: (Info -- Location cited in prior message) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(41): error 1927: (Note -- Symbol 'COXHashTable::m_nHashTableSize' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(41): error 1927: (Note -- Symbol 'COXHashTable::m_bCaseSensitive' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(41): error 1927: (Note -- Symbol 'COXHashTable::m_pHashTable' did not appear in the constructor initializer list -- Effective C++ #12) CommonConstruct(nHashTableSize); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(42): error 534: (Warning -- Ignoring return value of function 'COXHashTable::CommonConstruct(int)' (compare with line 81, file ..\..\Include\OXHashTable.h)) ..\..\Include\OXHashTable.h(81): error 830: (Info -- Location cited in prior message) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(46): error 1927: (Note -- Symbol 'COXHashTable::m_nHashTableSize' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(46): error 1927: (Note -- Symbol 'COXHashTable::m_bCaseSensitive' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(46): error 1927: (Note -- Symbol 'COXHashTable::m_pHashTable' did not appear in the constructor initializer list -- Effective C++ #12) CommonConstruct(67); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(47): error 534: (Warning -- Ignoring return value of function 'COXHashTable::CommonConstruct(int)' (compare with line 81, file ..\..\Include\OXHashTable.h)) ..\..\Include\OXHashTable.h(81): error 830: (Info -- Location cited in prior message) return InitHashTable(nHashTableSize); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(56): error 732: (Info -- Loss of sign (arg. no. 1) (int to unsigned int)) RemoveAll(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(61): error 1551: (Warning -- Function may throw exception '...' in destructor 'COXHashTable::~COXHashTable(void)' -- More Effective C++ #11 & Eff. C++ 3rd Ed. item 8) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(71): error 952: (Note -- Parameter 'bCase' (line 68) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(68): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(76): error 1762: (Info -- Member function 'COXHashTable::GetCaseSensitive(void)' could be made const --- Eff. C++ 3rd Ed. item 3) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(98): error 952: (Note -- Parameter 'nHashSize' (line 81) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(81): error 830: (Info -- Location cited in prior message) if (pNode == NULL) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(136): error 774: (Info -- Boolean within 'if' always evaluates to False [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp: lines 134, 136]) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(134): error 831: (Info -- Reference cited in prior message) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(136): error 831: (Info -- Reference cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(158): error 952: (Note -- Parameter 'dwData' (line 126) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(126): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(158): error 952: (Note -- Parameter 'sz' (line 126) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(126): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(169): error 953: (Note -- Variable 'pNode' (line 163) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(163): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(169): error 954: (Note -- Pointer variable 'pNode' (line 163) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(163): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(169): error 952: (Note -- Parameter 'sz' (line 160) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(160): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(207): error 953: (Note -- Variable 'nHashVal' (line 174) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(174): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(207): error 952: (Note -- Parameter 'sz' (line 171) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(171): error 830: (Info -- Location cited in prior message) nHashVal = (nHashVal<<5) + nHashVal + *sz++; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(219): error 737: (Info -- Loss of sign in promotion from int to unsigned int) if (_istupper(*sz)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(225): error 732: (Info -- Loss of sign (arg. no. 1) (char to unsigned int)) #... ( (*sz++)-'A'+'a' ) nHashVal = (nHashVal<<5) + nHashVal + _tolower(*sz++); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(226): error 834: (Info -- Operator '-' followed by operator '+' is confusing. Use parentheses.) nHashVal = (nHashVal<<5) + nHashVal + _tolower(*sz++); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(226): error 737: (Info -- Loss of sign in promotion from int to unsigned int) nHashVal = (nHashVal<<5) + nHashVal + *sz++; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(228): error 737: (Info -- Loss of sign in promotion from int to unsigned int) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(255): error 953: (Note -- Variable 'nHashVal' (line 238) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(238): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(255): error 952: (Note -- Parameter 'sz' (line 235) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(235): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(317): error 953: (Note -- Variable 'pNode' (line 302) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(302): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(317): error 954: (Note -- Pointer variable 'pNode' (line 302) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXHashTable.cpp(302): error 830: (Info -- Location cited in prior message) --- Global Wrap-up error 900: (Note -- Successful completion, 55 messages produced)