Lint Analysis Results Report for OXFolderPickerDlg.cpp |
Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp |
---|---|
Project: | UTStaticLib2008 |
Solution: | UsingStaticLib.sln [configuration: Debug] |
Analysis Status: | Complete |
Last Analysed: | 08 October 2008, 12:04:24 |
Total Issues: | 67 |
Elective Notes: | 21 (31.34%) |
Informational: | 33 (49.25%) |
Warnings: | 13 (19.40%) |
Errors: | 0 (0.00%) |
Internal Errors: | 0 (0.00%) |
Fatal Errors: | 0 (0.00%) |
User: | Anna |
Computer: | GABRIELLE |
Issue count by category ![]() Issue count by message number ![]() |
Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
---|---|---|---|---|---|---|
1 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 30 | Symbol 'COXFolderPickerDlg::m_cmbCurrentFolder's default constructor implicitly called -- Effective C++ #12 |
2 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 30 | Symbol 'COXFolderPickerDlg::m_treeShellFolders's default constructor implicitly called -- Effective C++ #12 |
3 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 30 | Symbol 'COXFolderPickerDlg::m_bOnlyFileSystemFolders' did not appear in the constructor initializer list -- Effective C++ #12 |
4 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 30 | Symbol 'COXFolderPickerDlg::m_bShowPopupMenu' did not appear in the constructor initializer list -- Effective C++ #12 |
5 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 30 | Symbol 'COXFolderPickerDlg::m_sCurrentFolder's default constructor implicitly called -- Effective C++ #12 |
6 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 30 | Symbol 'COXFolderPickerDlg::m_bErrorNotify' did not appear in the constructor initializer list -- Effective C++ #12 |
7 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 30 | Symbol 'COXFolderPickerDlg::m_bDisplayDesktopItem' did not appear in the constructor initializer list -- Effective C++ #12 |
8 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 30 | Symbol 'COXFolderPickerDlg::m_bShowFiles' did not appear in the constructor initializer list -- Effective C++ #12 |
9 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 30 | Symbol 'COXFolderPickerDlg::m_sFilter's default constructor implicitly called -- Effective C++ #12 |
10 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 30 | Symbol 'COXFolderPickerDlg::m_sTitle's default constructor implicitly called -- Effective C++ #12 |
11 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 40 | Loss of sign (arg. no. 1) (int to unsigned int) |
12 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 40 | do ... while(0); |
13 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 41 | Parameter 'bDisplayDesktopItem' (line 20) could be declared const --- Eff. C++ 3rd Ed. item 3 |
14 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 20 | Location cited in prior message |
15 | Information | 2 | 1746 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 41 | parameter 'sRootFolder' in function 'COXFolderPickerDlg::COXFolderPickerDlg(ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, int, int, int, int, const char *, int, CWnd *, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20 |
16 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 41 | Parameter 'sRootFolder' (line 19) could be declared const --- Eff. C++ 3rd Ed. item 3 |
17 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 19 | Location cited in prior message |
18 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 41 | Parameter 'lpszFilter' (line 24) could be declared const --- Eff. C++ 3rd Ed. item 3 |
19 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 24 | Location cited in prior message |
20 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 41 | Parameter 'bOnlyFileSystemFolders' (line 22) could be declared const --- Eff. C++ 3rd Ed. item 3 |
21 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 22 | Location cited in prior message |
22 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 41 | Parameter 'bErrorNotify' (line 25) could be declared const --- Eff. C++ 3rd Ed. item 3 |
23 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 25 | Location cited in prior message |
24 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 41 | Parameter 'bShowPopupMenu' (line 21) could be declared const --- Eff. C++ 3rd Ed. item 3 |
25 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 21 | Location cited in prior message |
26 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 41 | Parameter 'bShowFiles' (line 23) could be declared const --- Eff. C++ 3rd Ed. item 3 |
27 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 23 | Location cited in prior message |
28 | Information | 2 | 1746 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 41 | parameter 'sCurrentFolder' in function 'COXFolderPickerDlg::COXFolderPickerDlg(ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, int, int, int, int, const char *, int, CWnd *, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20 |
29 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 41 | Parameter 'sCurrentFolder' (line 18) could be declared const --- Eff. C++ 3rd Ed. item 3 |
30 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 18 | Location cited in prior message |
31 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 81 | Ignoring return value of function 'COXHistoryCombo::SetAutoPersistent(const char *, const char *, const char *)' (compare with line 319, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXHistoryCombo.h) |
32 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXHistoryCombo.h | 319 | Location cited in prior message |
33 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 87 | do ... while(0); |
34 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 95 | do ... while(0); |
35 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 96 | Ignoring return value of function 'COXShellFolderTree::OpenFolder(ATL::CStringT<char,StrTraitMFC_DLL<char>>, int)' (compare with line 240, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h) |
36 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h | 240 | Location cited in prior message |
37 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 99 | do ... while(0); |
38 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 101 | do ... while(0); |
39 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 117 | Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
40 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2509 | Location cited in prior message |
41 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 120 | Ignoring return value of function 'COXShellFolderTree::Refresh(struct _TREEITEM *)' (compare with line 484, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h) |
42 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h | 484 | Location cited in prior message |
43 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 127 | Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
44 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2509 | Location cited in prior message |
45 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 130 | Ignoring return value of function 'COXShellFolderTree::Refresh(struct _TREEITEM *)' (compare with line 484, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h) |
46 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h | 484 | Location cited in prior message |
47 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 137 | Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
48 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2509 | Location cited in prior message |
49 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 145 | Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
50 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2509 | Location cited in prior message |
51 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 148 | Ignoring return value of function 'COXShellFolderTree::Refresh(struct _TREEITEM *)' (compare with line 484, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h) |
52 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h | 484 | Location cited in prior message |
53 | Information | 2 | 826 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 154 | Suspicious pointer-to-pointer conversion (area too small) |
54 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 161 | Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
55 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2509 | Location cited in prior message |
56 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 165 | Variable 'htiSelected' (line 157) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
57 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 157 | Location cited in prior message |
58 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 165 | Variable 'pNMTreeView' (line 154) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
59 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 154 | Location cited in prior message |
60 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 165 | Pointer variable 'pNMTreeView' (line 154) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
61 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 154 | Location cited in prior message |
62 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 179 | Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
63 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2509 | Location cited in prior message |
64 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 188 | Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
65 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2509 | Location cited in prior message |
66 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp | 203 | Ignoring return value of function 'COXShellFolderTree::Refresh(struct _TREEITEM *)' (compare with line 484, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h) |
67 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h | 484 | Location cited in prior message |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp (C++) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(30): error 1926: (Note -- Symbol 'COXFolderPickerDlg::m_cmbCurrentFolder's default constructor implicitly called -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(30): error 1926: (Note -- Symbol 'COXFolderPickerDlg::m_treeShellFolders's default constructor implicitly called -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(30): error 1927: (Note -- Symbol 'COXFolderPickerDlg::m_bOnlyFileSystemFolders' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(30): error 1927: (Note -- Symbol 'COXFolderPickerDlg::m_bShowPopupMenu' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(30): error 1926: (Note -- Symbol 'COXFolderPickerDlg::m_sCurrentFolder's default constructor implicitly called -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(30): error 1927: (Note -- Symbol 'COXFolderPickerDlg::m_bErrorNotify' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(30): error 1927: (Note -- Symbol 'COXFolderPickerDlg::m_bDisplayDesktopItem' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(30): error 1927: (Note -- Symbol 'COXFolderPickerDlg::m_bShowFiles' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(30): error 1926: (Note -- Symbol 'COXFolderPickerDlg::m_sFilter's default constructor implicitly called -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(30): error 1926: (Note -- Symbol 'COXFolderPickerDlg::m_sTitle's default constructor implicitly called -- Effective C++ #12) #... f ( !(m_sTitle.LoadStringA(nIDTitle)) && AdvancedAssertFailedLine(_T("m_sT #... SERT(m_sTitle.LoadStringA(nIDTitle)) /*lint -restore */ VERIFY(m_sTitle.LoadString(nIDTitle)); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(40): error 732: (Info -- Loss of sign (arg. no. 1) (int to unsigned int)) #... E__) ) AfxDebugBreak() ; } while (0) /*lint -restore */ #... SERT(m_sTitle.LoadStringA(nIDTitle)) /*lint -restore */ VERIFY(m_sTitle.LoadString(nIDTitle)); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(40): error 717: (Info -- do ... while(0);) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(41): error 952: (Note -- Parameter 'bDisplayDesktopItem' (line 20) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(20): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(41): error 1746: (Info -- parameter 'sRootFolder' in function 'COXFolderPickerDlg::COXFolderPickerDlg(ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, int, int, int, int, const char *, int, CWnd *, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(41): error 952: (Note -- Parameter 'sRootFolder' (line 19) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(19): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(41): error 952: (Note -- Parameter 'lpszFilter' (line 24) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(24): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(41): error 952: (Note -- Parameter 'bOnlyFileSystemFolders' (line 22) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(22): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(41): error 952: (Note -- Parameter 'bErrorNotify' (line 25) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(25): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(41): error 952: (Note -- Parameter 'bShowPopupMenu' (line 21) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(21): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(41): error 952: (Note -- Parameter 'bShowFiles' (line 23) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(23): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(41): error 1746: (Info -- parameter 'sCurrentFolder' in function 'COXFolderPickerDlg::COXFolderPickerDlg(ATL::CStringT<char,StrTraitMFC_DLL<char>>, ATL::CStringT<char,StrTraitMFC_DLL<char>>, int, int, int, int, const char *, int, CWnd *, int)' could be made const reference -- Effective C++ #22 & Eff. C++ 3rd Ed. item 3& Eff. C++ 3rd Ed. item 20) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(41): error 952: (Note -- Parameter 'sCurrentFolder' (line 18) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(18): error 830: (Info -- Location cited in prior message) m_cmbCurrentFolder.SetAutoPersistent(_T("Current Folder")); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(81): error 534: (Warning -- Ignoring return value of function 'COXHistoryCombo::SetAutoPersistent(const char *, const char *, const char *)' (compare with line 319, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXHistoryCombo.h)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXHistoryCombo.h(319): error 830: (Info -- Location cited in prior message) #... IS_FILE, __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */ #... -e534 -e1551 */ASSERT(sTitle.LoadStringA(26962)) /*lint -restore */ VERIFY(sTitle.LoadString(IDS_OX_FOLDERPICKERTITLE));//"Shell Namespace" D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(87): error 717: (Info -- do ... while(0);) #... ), THIS_FILE, __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */ #... SSERT(m_treeShellFolders.InitializeTree(m_sRootFolder)) /*lint -restore */ VERIFY(m_treeShellFolders.InitializeTree(m_sRootFolder)); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(95): error 717: (Info -- do ... while(0);) m_treeShellFolders.OpenFolder(m_sCurrentFolder); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(96): error 534: (Warning -- Ignoring return value of function 'COXShellFolderTree::OpenFolder(ATL::CStringT<char,StrTraitMFC_DLL<char>>, int)' (compare with line 240, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h(240): error 830: (Info -- Location cited in prior message) #... S_FILE, __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */ #... -e534 -e1551 */ASSERT(sTitle.LoadStringA(26963)) /*lint -restore */ VERIFY(sTitle.LoadString(IDS_OX_FOLDERPICKERROOT));//" [ Root Folder - " D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(99): error 717: (Info -- do ... while(0);) #... , THIS_FILE, __LINE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */ #... ve -e534 -e1551 */ASSERT(sDesktop.LoadStringA(26964)) /*lint -restore */ VERIFY(sDesktop.LoadString(IDS_OX_FOLDERPICKERDESKTOP));//"Desktop" D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(101): error 717: (Info -- do ... while(0);) UpdateData(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(117): error 534: (Warning -- Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2509): error 830: (Info -- Location cited in prior message) m_treeShellFolders.Refresh(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(120): error 534: (Warning -- Ignoring return value of function 'COXShellFolderTree::Refresh(struct _TREEITEM *)' (compare with line 484, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h(484): error 830: (Info -- Location cited in prior message) UpdateData(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(127): error 534: (Warning -- Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2509): error 830: (Info -- Location cited in prior message) m_treeShellFolders.Refresh(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(130): error 534: (Warning -- Ignoring return value of function 'COXShellFolderTree::Refresh(struct _TREEITEM *)' (compare with line 484, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h(484): error 830: (Info -- Location cited in prior message) UpdateData(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(137): error 534: (Warning -- Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2509): error 830: (Info -- Location cited in prior message) UpdateData(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(145): error 534: (Warning -- Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2509): error 830: (Info -- Location cited in prior message) m_treeShellFolders.Refresh(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(148): error 534: (Warning -- Ignoring return value of function 'COXShellFolderTree::Refresh(struct _TREEITEM *)' (compare with line 484, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h(484): error 830: (Info -- Location cited in prior message) NM_TREEVIEW* pNMTreeView=(NM_TREEVIEW*)pNMHDR; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(154): error 826: (Info -- Suspicious pointer-to-pointer conversion (area too small)) UpdateData(FALSE); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(161): error 534: (Warning -- Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2509): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(165): error 953: (Note -- Variable 'htiSelected' (line 157) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(157): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(165): error 953: (Note -- Variable 'pNMTreeView' (line 154) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(154): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(165): error 954: (Note -- Pointer variable 'pNMTreeView' (line 154) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(154): error 830: (Info -- Location cited in prior message) UpdateData(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(179): error 534: (Warning -- Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2509): error 830: (Info -- Location cited in prior message) UpdateData(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(188): error 534: (Warning -- Ignoring return value of function 'CWnd::UpdateData(int)' (compare with line 2509, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2509): error 830: (Info -- Location cited in prior message) m_treeShellFolders.Refresh(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXFolderPickerDlg.cpp(203): error 534: (Warning -- Ignoring return value of function 'COXShellFolderTree::Refresh(struct _TREEITEM *)' (compare with line 484, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\Include\OXShellFolderTree.h(484): error 830: (Info -- Location cited in prior message) --- Global Wrap-up error 900: (Note -- Successful completion, 67 messages produced)