Lint Analysis Results Report for OXDlgBar.cpp |
Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp |
---|---|
Project: | UTStaticLib2008 |
Solution: | UsingStaticLib.sln [configuration: Debug] |
Analysis Status: | Complete |
Last Analysed: | 08 October 2008, 12:03:16 |
Total Issues: | 39 |
Elective Notes: | 10 (25.64%) |
Informational: | 22 (56.41%) |
Warnings: | 7 (17.95%) |
Errors: | 0 (0.00%) |
Internal Errors: | 0 (0.00%) |
Fatal Errors: | 0 (0.00%) |
User: | Anna |
Computer: | GABRIELLE |
Issue count by category ![]() Issue count by message number ![]() |
Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
---|---|---|---|---|---|---|
1 | Warning | 3 | 544 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 30 | endif or else not followed by EOL |
2 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 56 | Symbol 'CControlBar' did not appear in the constructor initializer list -- Effective C++ #12 |
3 | Elective Note | 1 | 1926 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 56 | Symbol 'COXDialogBar::m_sizeDefault's default constructor implicitly called -- Effective C++ #12 |
4 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 56 | Symbol 'COXDialogBar::m_pOccDialogInfo' did not appear in the constructor initializer list -- Effective C++ #12 |
5 | Elective Note | 1 | 1927 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 56 | Symbol 'COXDialogBar::m_lpszTemplateName' did not appear in the constructor initializer list -- Effective C++ #12 |
6 | Warning | 3 | 1506 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 65 | Call to virtual function 'CControlBar::DestroyWindow(void)' within a constructor or destructor --- Eff. C++ 3rd Ed. item 9 |
7 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 65 | Ignoring return value of function 'CControlBar::DestroyWindow(void)' (compare with line 189, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxext.h) |
8 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxext.h | 189 | Location cited in prior message |
9 | Warning | 3 | 1551 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 65 | Function may throw exception '...' in destructor 'COXDialogBar::~COXDialogBar(void)' -- More Effective C++ #11 & Eff. C++ 3rd Ed. item 8 |
10 | Information | 2 | 1740 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 66 | pointer member 'COXDialogBar::m_pOccDialogInfo' (line 100, file ..\..\Include\oxdlgbar.h) not directly freed or zeroed by destructor -- Effective C++ #6 |
11 | Information | 2 | 830 | ..\..\Include\oxdlgbar.h | 100 | Location cited in prior message |
12 | Information | 2 | 1740 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 66 | pointer member 'COXDialogBar::m_lpszTemplateName' (line 101, file ..\..\Include\oxdlgbar.h) not directly freed or zeroed by destructor -- Effective C++ #6 |
13 | Information | 2 | 830 | ..\..\Include\oxdlgbar.h | 101 | Location cited in prior message |
14 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 70 | do ... while(0); |
15 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 82 | Loss of precision (assignment) (unsigned long to long) |
16 | Warning | 3 | 613 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 85 | Possible use of null pointer 'pParentWnd' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp: line 70] |
17 | Information | 2 | 831 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 70 | Reference cited in prior message |
18 | Information | 2 | 713 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 94 | Loss of precision (arg. no. 1) (unsigned int to int) |
19 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 94 | Ignoring return value of function 'CWnd::SetDlgCtrlID(int)' (compare with line 2194, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
20 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2194 | Location cited in prior message |
21 | Warning | 3 | 534 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 100 | Ignoring return value of function 'CWnd::ModifyStyle(unsigned long, unsigned long, unsigned int)' (compare with line 2105, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h) |
22 | Information | 2 | 830 | C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h | 2105 | Location cited in prior message |
23 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 103 | Parameter 'nStyle' (line 68) could be declared const --- Eff. C++ 3rd Ed. item 3 |
24 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 68 | Location cited in prior message |
25 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 130 | do ... while(0); |
26 | Information | 2 | 826 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 137 | Suspicious pointer-to-pointer conversion (area too small) |
27 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 146 | Pointer variable 'lpDialogTemplate' (line 110) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
28 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 110 | Location cited in prior message |
29 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 146 | Variable 'bSuccess' (line 137) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
30 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 137 | Location cited in prior message |
31 | Information | 2 | 826 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 137 | Suspicious pointer-to-pointer conversion (area too small) |
32 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 155 | Parameter 'bStretch' (line 148) could be declared const --- Eff. C++ 3rd Ed. item 3 |
33 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 148 | Location cited in prior message |
34 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 155 | Parameter 'bHorz' (line 148) could be declared const --- Eff. C++ 3rd Ed. item 3 |
35 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 148 | Location cited in prior message |
36 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 178 | do ... while(0); |
37 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 187 | Variable 'pOccManager' (line 175) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
38 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 175 | Location cited in prior message |
39 | Information | 2 | 750 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp | 29 | local macro '__OX_OCCIMPL_H__' (line 29, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp) not referenced |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp (C++) #endif __OX_OCCIMPL_H__ D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(30): error 544: (Warning -- endif or else not followed by EOL) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(56): error 1928: (Note -- Symbol 'CControlBar' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(56): error 1926: (Note -- Symbol 'COXDialogBar::m_sizeDefault's default constructor implicitly called -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(56): error 1927: (Note -- Symbol 'COXDialogBar::m_pOccDialogInfo' did not appear in the constructor initializer list -- Effective C++ #12) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(56): error 1927: (Note -- Symbol 'COXDialogBar::m_lpszTemplateName' did not appear in the constructor initializer list -- Effective C++ #12) DestroyWindow(); // avoid PostNcDestroy problems D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(65): error 1506: (Warning -- Call to virtual function 'CControlBar::DestroyWindow(void)' within a constructor or destructor --- Eff. C++ 3rd Ed. item 9) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(65): error 534: (Warning -- Ignoring return value of function 'CControlBar::DestroyWindow(void)' (compare with line 189, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxext.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxext.h(189): error 830: (Info -- Location cited in prior message) DestroyWindow(); // avoid PostNcDestroy problems D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(65): error 1551: (Warning -- Function may throw exception '...' in destructor 'COXDialogBar::~COXDialogBar(void)' -- More Effective C++ #11 & Eff. C++ 3rd Ed. item 8) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(66): error 1740: (Info -- pointer member 'COXDialogBar::m_pOccDialogInfo' (line 100, file ..\..\Include\oxdlgbar.h) not directly freed or zeroed by destructor -- Effective C++ #6) ..\..\Include\oxdlgbar.h(100): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(66): error 1740: (Info -- pointer member 'COXDialogBar::m_lpszTemplateName' (line 101, file ..\..\Include\oxdlgbar.h) not directly freed or zeroed by destructor -- Effective C++ #6) ..\..\Include\oxdlgbar.h(101): error 830: (Info -- Location cited in prior message) #... ebugBreak() ; } while (0) /*lint -restore */ ASSERT(pParentWnd != NULL); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(70): error 717: (Info -- do ... while(0);) cs.style = (DWORD)nStyle | WS_CHILD; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(82): error 713: (Info -- Loss of precision (assignment) (unsigned long to long)) cs.hwndParent = pParentWnd->GetSafeHwnd(); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(85): error 613: (Warning -- Possible use of null pointer 'pParentWnd' in left argument to operator '->' [Reference: file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp: line 70]) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(70): error 831: (Info -- Reference cited in prior message) SetDlgCtrlID(nID); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(94): error 713: (Info -- Loss of precision (arg. no. 1) (unsigned int to int)) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(94): error 534: (Warning -- Ignoring return value of function 'CWnd::SetDlgCtrlID(int)' (compare with line 2194, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2194): error 830: (Info -- Location cited in prior message) ModifyStyle(0, WS_CLIPSIBLINGS); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(100): error 534: (Warning -- Ignoring return value of function 'CWnd::ModifyStyle(unsigned long, unsigned long, unsigned int)' (compare with line 2105, file C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h)) C:\Program Files\Microsoft Visual Studio 9.0\VC\atlmfc\include\afxwin.h(2105): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(103): error 952: (Note -- Parameter 'nStyle' (line 68) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(68): error 830: (Info -- Location cited in prior message) #... ) AfxDebugBreak() ; } while (0) /*lint -restore */ ASSERT(lpDialogTemplate != NULL); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(130): error 717: (Info -- do ... while(0);) BOOL bSuccess = CreateDlgIndirect((LPDLGTEMPLATE)lpDialogTemplate, pParentWnd, NULL); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(137): error 826: (Info -- Suspicious pointer-to-pointer conversion (area too small)) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(146): error 954: (Note -- Pointer variable 'lpDialogTemplate' (line 110) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(110): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(146): error 953: (Note -- Variable 'bSuccess' (line 137) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(137): error 830: (Info -- Location cited in prior message) During Specific Walk: File D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp line 89: COXDialogBar::CreateMemDialog(0?) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(137): error 826: (Info -- Suspicious pointer-to-pointer conversion (area too small)) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(155): error 952: (Note -- Parameter 'bStretch' (line 148) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(148): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(155): error 952: (Note -- Parameter 'bHorz' (line 148) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(148): error 830: (Info -- Location cited in prior message) #... NE__) ) AfxDebugBreak() ; } while (0) /*lint -restore */ ASSERT(m_lpszTemplateName != NULL); D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(178): error 717: (Info -- do ... while(0);) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(187): error 953: (Note -- Variable 'pOccManager' (line 175) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(175): error 830: (Info -- Location cited in prior message) --- Wrap-up for Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp(29): error 750: (Info -- local macro '__OX_OCCIMPL_H__' (line 29, file D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXDlgBar.cpp) not referenced) --- Global Wrap-up error 900: (Note -- Successful completion, 39 messages produced)