Lint Analysis Results Report for OXCRCChk.CPP |
Implementation file: | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP |
---|---|
Project: | UTStaticLib2008 |
Solution: | UsingStaticLib.sln [configuration: Debug] |
Analysis Status: | Complete |
Last Analysed: | 08 October 2008, 11:59:57 |
Total Issues: | 42 |
Elective Notes: | 20 (47.62%) |
Informational: | 22 (52.38%) |
Warnings: | 0 (0.00%) |
Errors: | 0 (0.00%) |
Internal Errors: | 0 (0.00%) |
Fatal Errors: | 0 (0.00%) |
User: | Anna |
Computer: | GABRIELLE |
Issue count by category ![]() Issue count by message number ![]() |
Order | Category | Severity | Issue No. | Source File | Line No. | Issue Text |
---|---|---|---|---|---|---|
1 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 32 | Symbol 'CObject' did not appear in the constructor initializer list -- Effective C++ #12 |
2 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 33 | Parameter 'eSize' (line 29) could be declared const --- Eff. C++ 3rd Ed. item 3 |
3 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 29 | Location cited in prior message |
4 | Information | 2 | 1752 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 61 | catch parameter is not a reference -- More Effective C++ #13 |
5 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 61 | do ... while(0); |
6 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 78 | Variable 'nOldCheck32' (line 48) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
7 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 48 | Location cited in prior message |
8 | Information | 2 | 1752 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 92 | catch parameter is not a reference -- More Effective C++ #13 |
9 | Information | 2 | 717 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 92 | do ... while(0); |
10 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 100 | Parameter 'sFileName' (line 80) could be declared const --- Eff. C++ 3rd Ed. item 3 |
11 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 80 | Location cited in prior message |
12 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 113 | Parameter 'nCount' (line 107) could be declared const --- Eff. C++ 3rd Ed. item 3 |
13 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 107 | Location cited in prior message |
14 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 113 | Parameter 'nSeed' (line 107) could be declared const --- Eff. C++ 3rd Ed. item 3 |
15 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 107 | Location cited in prior message |
16 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 126 | Parameter 'nCount' (line 120) could be declared const --- Eff. C++ 3rd Ed. item 3 |
17 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 120 | Location cited in prior message |
18 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 126 | Parameter 'nSeed' (line 120) could be declared const --- Eff. C++ 3rd Ed. item 3 |
19 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 120 | Location cited in prior message |
20 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 139 | Parameter 'nCount' (line 133) could be declared const --- Eff. C++ 3rd Ed. item 3 |
21 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 133 | Location cited in prior message |
22 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 139 | Parameter 'nSeed' (line 133) could be declared const --- Eff. C++ 3rd Ed. item 3 |
23 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 133 | Location cited in prior message |
24 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 151 | Symbol 'COXCRCTableList' did not appear in the constructor initializer list -- Effective C++ #12 |
25 | Information | 2 | 701 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 163 | Shift left of signed quantity (int) |
26 | Information | 2 | 701 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 171 | Shift left of signed quantity (int) |
27 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 176 | Variable 'pTable' (line 156) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
28 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 156 | Location cited in prior message |
29 | Elective Note | 1 | 1961 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 176 | virtual member function 'COXCRC16::CTableList::CreateTable(unsigned short)' could be made const --- Eff. C++ 3rd Ed. item 3 |
30 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 196 | Pointer variable 'p' (line 187) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
31 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 187 | Location cited in prior message |
32 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 196 | Parameter 'nSeed' (line 185) could be declared const --- Eff. C++ 3rd Ed. item 3 |
33 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 185 | Location cited in prior message |
34 | Elective Note | 1 | 1928 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 204 | Symbol 'COXCRCTableList' did not appear in the constructor initializer list -- Effective C++ #12 |
35 | Information | 2 | 732 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 216 | Loss of sign (assignment) (int to unsigned long) |
36 | Elective Note | 1 | 953 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 227 | Variable 'pTable' (line 209) could be declared as const --- Eff. C++ 3rd Ed. item 3 |
37 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 209 | Location cited in prior message |
38 | Elective Note | 1 | 1961 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 227 | virtual member function 'COXCRC32::CTableList::CreateTable(unsigned long)' could be made const --- Eff. C++ 3rd Ed. item 3 |
39 | Elective Note | 1 | 954 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 254 | Pointer variable 'p' (line 241) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3 |
40 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 241 | Location cited in prior message |
41 | Elective Note | 1 | 952 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 254 | Parameter 'nSeed' (line 237) could be declared const --- Eff. C++ 3rd Ed. item 3 |
42 | Information | 2 | 830 | D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP | 237 | Location cited in prior message |
--- Module: D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP (C++) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(32): error 1928: (Note -- Symbol 'CObject' did not appear in the constructor initializer list -- Effective C++ #12) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(33): error 952: (Note -- Parameter 'eSize' (line 29) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(29): error 830: (Info -- Location cited in prior message) #... } catch (CFileException* e) { ASSERT(e->IsKindOf(RUNTIME_CLASS(CFileExcept CATCH(CFileException, e) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(61): error 1752: (Info -- catch parameter is not a reference -- More Effective C++ #13) #... xDebugBreak() ; } while (0) /*lint -restore */ #... IME_CLASS(CFileException))); _afxExceptionLink.m_pException = e; CATCH(CFileException, e) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(61): error 717: (Info -- do ... while(0);) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(78): error 953: (Note -- Variable 'nOldCheck32' (line 48) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(48): error 830: (Info -- Location cited in prior message) #... tch (CFileException* e) { ASSERT(e->IsKindOf(RUNTIME_CLASS(CFileException) CATCH(CFileException, e) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(92): error 1752: (Info -- catch parameter is not a reference -- More Effective C++ #13) #... ugBreak() ; } while (0) /*lint -restore */ #... CLASS(CFileException))); _afxExceptionLink.m_pException = e; CATCH(CFileException, e) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(92): error 717: (Info -- do ... while(0);) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(100): error 952: (Note -- Parameter 'sFileName' (line 80) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(80): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(113): error 952: (Note -- Parameter 'nCount' (line 107) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(107): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(113): error 952: (Note -- Parameter 'nSeed' (line 107) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(107): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(126): error 952: (Note -- Parameter 'nCount' (line 120) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(120): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(126): error 952: (Note -- Parameter 'nSeed' (line 120) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(120): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(139): error 952: (Note -- Parameter 'nCount' (line 133) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(133): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(139): error 952: (Note -- Parameter 'nSeed' (line 133) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(133): error 830: (Info -- Location cited in prior message) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(151): error 1928: (Note -- Symbol 'COXCRCTableList' did not appear in the constructor initializer list -- Effective C++ #12) k = i << 8; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(163): error 701: (Info -- Shift left of signed quantity (int)) k <<= 1; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(171): error 701: (Info -- Shift left of signed quantity (int)) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(176): error 953: (Note -- Variable 'pTable' (line 156) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(156): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(176): error 1961: (Note -- virtual member function 'COXCRC16::CTableList::CreateTable(unsigned short)' could be made const --- Eff. C++ 3rd Ed. item 3) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(196): error 954: (Note -- Pointer variable 'p' (line 187) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(187): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(196): error 952: (Note -- Parameter 'nSeed' (line 185) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(185): error 830: (Info -- Location cited in prior message) { D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(204): error 1928: (Note -- Symbol 'COXCRCTableList' did not appear in the constructor initializer list -- Effective C++ #12) nCRC = i; D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(216): error 732: (Info -- Loss of sign (assignment) (int to unsigned long)) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(227): error 953: (Note -- Variable 'pTable' (line 209) could be declared as const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(209): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(227): error 1961: (Note -- virtual member function 'COXCRC32::CTableList::CreateTable(unsigned long)' could be made const --- Eff. C++ 3rd Ed. item 3) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(254): error 954: (Note -- Pointer variable 'p' (line 241) could be declared as pointing to const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(241): error 830: (Info -- Location cited in prior message) } D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(254): error 952: (Note -- Parameter 'nSeed' (line 237) could be declared const --- Eff. C++ 3rd Ed. item 3) D:\Projects\AddIns\Visual Lint\Test Solutions\VS2008\UltimateToolbox93_samples\Ultimate Toolbox\source\OXCRCChk.CPP(237): error 830: (Info -- Location cited in prior message) --- Global Wrap-up error 900: (Note -- Successful completion, 42 messages produced)